Hello all you Monks!

I am opening a file and want to check for a line and make a substitution or if the line does not exist write a new line. The straight substitution work well. The one to write the IP is the problem.

What is happening is that the new line is getting written after each existing line instead of getting written once.

Here is my code:

print "Please enter the ip address for this machine.  This will be eth
+0:\n";
my $ip = <>;
chomp $ip;
my $if0 = "ifcfg-eth0";
my $if1 = "ifcfg-eth1";
my $ifdir = 'network-scripts';
my $ifsub1 = "IPADDR=";
my $ifsub2 = "BOOTPROTO=";
my $ifsub3 = "none";
open (IP, "<", "$dir/$sys/$ifdir/$if0");
open (NEW, ">", "$dir/$sys/$ifdir/$if0.new");
while (<IP>){
        s/^$ifsub2.*/$ifsub2$ifsub3/;
        s/^$ifsub1.*/$ifsub1$ip/ || print "$ifsub1$ip\n";
        print $_;
        #print "$ifsub1$ip\n";  <==I tried it here too
}
close IP;
close NEW;

[download]

Here is the output:

IPADDR=1.1.1.1
# Advanced Micro Devices [AMD] 79c970 [PCnet32 LANCE]
IPADDR=1.1.1.1
DEVICE=eth0
IPADDR=1.1.1.1
BOOTPROTO=none
IPADDR=1.1.1.1
DHCPCLASS=
IPADDR=1.1.1.1
HWADDR=00:0C:29:97:01:F3
IPADDR=1.1.1.1
ONBOOT=yes

[download]

The original file looks like this:

# Advanced Micro Devices [AMD] 79c970 [PCnet32 LANCE]
DEVICE=eth0
BOOTPROTO=dhcp
DHCPCLASS=
HWADDR=00:0C:29:97:01:F3
ONBOOT=yes

[download]

Thanks for your help!

John

In reply to How to write a new line in a while loop? by xjlittle

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.