($key=~m{^\d+$} ? "fid" : "name") => ($key=~m{^\d+$} ? $key : lc($key =~ s/[^a-z0-9]/_/ig))

Do you think that's readable? And you want to add to it? Whoa! 

sub add_record {
    my ($self, $data) = @_;
    my @record;
    for my $key (keys %$data) {
        my $att_key = $key =~ /[^0-9]/ ? "name" : "fid";
        ( my $att_val = lc($key) ) =~ s/[^a-z0-9]/_/g;
        push @record, {
            tag   => "field", 
            atts  => { $att_key => $att_val },
            value => $data->{$key},
        };
    }
    return post_api("API_AddRecord", \@record);
}

[download]

By the way, don't use prototypes! You didn't even use the right one, so that means you have to bypass it to call your sub!

In reply to Re: Using s/// Inline by ikegami
in thread Using s/// Inline by Jason Hutchinson

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.