Why jump through all those hoops? On the face of it all you need is:

#! /usr/bin/perl env
use strict;
use warnings;
use Data::Dumper;

my %record;
while (my $line = <DATA>) {
    chomp $line;
    
    my ($key, $val) = split /:\s*/, $line, 2;

    $record{$key} = $val if defined $val;
}

print Dumper (\%record);

__DATA__
Name: Sam
Address: Mascot
Ph.No: 123321

[download]

Prints:

$VAR1 = {
          'Ph.No' => '123321',
          'Address' => 'Mascot',
          'Name' => 'Sam'
        };

[download]

Note though that I added a chomp (most of your values would otherwise have a trailing new line), limited split to finding two elements to avoid chopping off the end of any value that happens to contain a colon and check to see that there is in fact a value field on the line.

True laziness is hard work

In reply to Re: Hash Add new elements through loop by GrandFather
in thread Hash Add new elements through loop by tart

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.