shravnk:

So you're prompting the user for a filename, and verifying that it contains ".nml" or ".xml". If it doesn't contain that, you print an error message and continue on. Hmmm....

You really want to stop your program when you find a problem, so you should use the die function rather than print on line 8.

Another problem is that with the expression you've given "foo.xml.abc.def" is a valid filename.

After you open the file, you then read the first line of the file, and treat it as a filename to pass to parsefile. Unless your file contains the name of the XML file you're trying to process, that's going to be a bit of a problem...

Also, you have *another* open statement you haven't checked yet...

...roboticus

In reply to Re^3: XML::Twig Help by roboticus
in thread XML::Twig Help by shravnk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.