A simple fix would be to do a few checks before you make the substitution:

use strict;
use warnings;
use Data::Dumper qw{Dumper};

my %hash = (
        'GREETING1'    => 'HAI',
        'GREETING2'  => 'HELLO',
);

              
my $value = '-GREETING1- James -POSITION- -GREETING2- -FOO-';

## find potential matches
my @matches = $value =~ m/-([^\-\s]+)-/g;

## give summary
print "" . (scalar@matches) . " matches for >>$value<<:\n" . (Dumper \
+@matches);

## check each potential match before substituting
for my $match (@matches){
    if (exists$hash{$match}){ # recognised?
        ## make substitution, including updates on string
        print "\t>$match< replaced:\n";
        print "\tWAS : $value\n";
        $value =~s/-$match-/$hash{$match}/;
        print "\tNOW : $value\n";
    }
    else { print "$match not replaced.\n"; }
}
[download]

Gives:

4 matches for >>-GREETING1- James -POSITION- -GREETING2- -FOO-<<:
$VAR1 = [
          'GREETING1',
          'POSITION',
          'GREETING2',
          'FOO'
        ];
    >GREETING1< replaced:
    WAS : -GREETING1- James -POSITION- -GREETING2- -FOO-
    NOW : HAI James -POSITION- -GREETING2- -FOO-
POSITION not replaced.
    >GREETING2< replaced:
    WAS : HAI James -POSITION- -GREETING2- -FOO-
    NOW : HAI James -POSITION- HELLO -FOO-
FOO not replaced.
[download]

Not a one liner, but maybe a bit clearer to follow and easier to expand later... HTH!

Updated: Added some comments...

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.