Expensive? How much text are you putting out to the screen before the "inefficiency" is noticeable? It's a little premature to be optimizing at this time.


But consider what you were doing with the code you posted. You want to attron a color pair each time you encounter a yellow escape sequence. That seems like quite a customized requirement.

You're using Curses and Term::ANSIColor, so you're leveraging a lot already = good for you! I did a cursory search and couldn't find any more helpful modules beyond those two.

I'd write formatted_text() using a dispatch hash. Also made the regex quantifier non-greedy: 
my %esc2action = (
    color('yellow') => sub { attron(COLOR_PAIR(1)) },
    color('reset') => sub { attroff(COLOR_PAIR(1)) },
);

sub formatted_text {
    my ($win, $text) = @_;

    # tokenize text on escape sequences
    for my $token (split /(\e\[[^m]+?m)/, $text) {
        my $act = $esc2action{$token};

        if ($act) {
            $act->();
        }
        else {
            addstr($win, $token);
        }
    }
}

[download]

In reply to Re^3: Handling ANSI Escape Sequences for Printing to Curses by repellent
in thread Handling ANSI Escape Sequences for Printing to Curses by atancasis

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.