Your inner loop:
foreach $ip(@ip) {
print $out "#" if(/\b$ip\b/i && !/^#/); #only one # at front of lin
+e
print $out $_;
}
Calls "print $out" once for each item in @ip, causing double lines.
The simplest fix (untested) is early exit:
foreach $ip(@ip) {
last if /^#/; # ALready has a hash . Note - LAST exists this loop
next unless /\b$ip\b/i; # No match - so try the next item
print $out "#";
last; # Remember to exit loop after one successful match
}
print $_; # Print onloy once.
When you are ready, take the next step and learn regex alternation, for a more efficient solution.
Syntactic sugar causes cancer of the semicolon. --Alan Perlis
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.