if ( $content =~ /\t/ ) {
    $content =~ s/\t//g;
}

[download]

Why are you testing for /\t/ first?    If the substitution operator doesn't find a "\t" it will not remove anything so the first test is superfluous.    And would probably would be better to use the tr/// operator anyway: 

$content =~ tr/\t//d;

[download]


    if ( $line =~ /CONTACT/ ) {
        $line =~ s/CONTACT//;

[download]

Why are you testing for /CONTACT/ first?    Just use the substitution operator in the test: 

    if ( $line =~ s/CONTACT// ) {

[download]


                if ( $line =~ /(.+?)=.+/ ) {
                    unless ( $cols{$1} and $cols{$1} == 1 ) {
                        $cols{ ucfirst lc $1 } = 1;
                        push @cols, ucfirst lc $1;
                    }

[download]

You are testing for an unmodified $1 but you are storing a modified $1 in the hash so how is the test supposed to work correctly?    And why the two tests on $cols{$1} when the value can only ever be either 1 or undef? 



        if ( $$row{$_} ) {
            push @rows, $$row{$_};
        }

[download]

$$row{$_} is usually written as $row->{$_}.


In reply to Re: Convert Opera Contacts in .adr format to csv by jwkrahn
in thread Convert Opera Contacts in .adr format to csv by walto

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.