$data .=chomp($_);

anish_batra's solution is broken. chomp has as its return value the number of characters chomped from its parameter. You're appending a chomp-count to $data rather than the line that was just read from the filehandle.

The rest of the solution is just a mess.

Don't read a filehandle inside of a foreach like that. Don't specify elsif to negate the base condition; that's what else does. Don't bother testing whether the line is blank; allowing an empty string to be appended doesn't hurt anything. And where is the test for open failure?

Unless there's a specific reason to use them, bareword typeglob filehandles and two-arg open have largely drifted out of favor as well.


Dave

In reply to Re^2: read file into 1 line string by davido
in thread read file into 1 line string by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.