Dear Monks, what I am missing? I have these 2 subrutines: if I run create_file a new file is created, but I if I run it after running the subrutine open_directory_file (which reads the files stored in a directory) the other subrutine gives me errors, namely that I am trying to write on close filehandle MYFILE. Why? Thanks 

my $output_directory="TEMPORARY";

sub open_directory_file
{
print "Open files from directory...\n";
my @all_file_contents;

my $Directory = File::Spec->canonpath( $mw->chooseDirectory() );
my $shortpath = Win32::GetShortPathName( "$Directory" );
chdir($shortpath) or die "$!";

opendir (DIR, "$shortpath") or die "$!";
my @files = grep {/.*?\.txt/}  readdir DIR;
close DIR;
}

sub create_file{
open (MYFILE, ">$output_directory/token.txt");
print MYFILE "ciao";
close (MYFILE); 
}

[download]

The working subrutine open_directory_file (thanks roboticus for the hint!) 


my $output_directory="TEMPORARY";

sub open_directory_file
{
print "Open files from directory...\n";
my @all_file_contents;

#added following line
my $pwd = cwd();

my $Directory = File::Spec->canonpath( $mw->chooseDirectory() );
my $shortpath = Win32::GetShortPathName( "$Directory" );
chdir($shortpath) or die "$!";

opendir (DIR, "$shortpath") or die "$!";
my @files = grep {/.*?\.txt/}  readdir DIR;
close DIR;

#added following line
#go back to original directory
chdir($pwd);
}

[download]

In reply to TK filehandle path by welle

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.