I wonder if you are missing quotes in your second if.

I'm guessing that you also need to put quotes around your strings in what I'm guessing you want to be a string eval (the second if). The string you want to evaluate should probably be something like "'string' eq 'string'".

It might help you to examine what you are evaluating. You might use the debugger but I would probably use print or warn myself. Something like:

        if (eval "$hash{$filter[0]->[0]} $filter[0]->[1] $filter[0]->[
+2]")
        {
            print "eval \"$hash{$filter[1]->[0]} $filter[1]->[1] $filt
+er[1]->[2]\"";
            if (eval "$hash{$filter[1]->[0]} $filter[1]->[1] $filter[1
+]->[2]")
            {
                if (eval "$hash{$filter[2]->[0]} $filter[2]->[1] $filt
+er[2]->[2]")
                {
                    print OUTFILE $line, "\n";
                }    
            }
        }

[download]

When you see what you are evaluating, the problem will likely become evident.

FWIW: I don't think I would use eval as you are trying to. I would probably do something more like the follwing:

    sub match {
        my ($hash, $filter) = @_;

        if($filter->[1] eq '<=') {
            return( $hash{$filter->[0]} <= $filter->[2] );
        } elsif($filter->[1] eq 'eq') {
            return( $hash{$filter->[0]} eq $filter->[2] );
        } else {
            die "unsupported comparator: $filter->[$index]->[1]";
        }
    }

    if(
        match($hash, $filters->[0]) and
        match($hash, $filters->[1]) and
        match($hash, $filters->[2]) 
    ) {
        print OUTFILE $line, "\n";
    }

[download]

If I was going to use eval, I would definitely check for errors after each eval. I suspect if you did so, you would find that the eval in your second if gives a compile error - but it's only a guess. If you did add error handling to your implementation with eval, I would find it even harder to read than what you have currently, which is already too hard for my taste, but that's just me. In any case, if you want to know why your program isn't doing what you expect, a very good place to start is error handling and reporting. To this end, you might find strict and warnings helpful.

In reply to Re: Problem when comparing strings as opposed to numerical values by ig
in thread Problem when comparing strings as opposed to numerical values by dkhalfe

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.