Avoid needless slurping. Use while (<DATA>) instead of introducing an extra variable, slurping into it and using a for loop.

Slurping complicates the code (there are more moving parts), it doesn't scale well, it obscures the intent of the code because it decouples line reading from line processing, and it probably doesn't offer any useful efficiency gains (which shouldn't be a consideration in the first place).

You code could be "cleaned up" as:

#!/usr/bin/env perl
use strict;
use warnings;

my @code_file;
my @var_file;
my $label_line;

while (<DATA>) {
    if (/\s+EQU\s+\*/) {
        $label_line = $_;
        next;
    }

    next if ! $label_line;
    
    push @{/\A\s*DC/ ? \@var_file : \@code_file}, "$label_line$_";
    $label_line = '';
}

print join "\n", "CODE_FILE:", @code_file, "VARIABLE_FILE:", @var_file
+;

__DATA__
LABEL#1 EQU *
     $MAC ABORT 

LABEL#2  EQU   *
     $NOT UPDATE,STOP

T#TAB1   EQU   *
   DC    AL4(-1)

[download]
True laziness is hard work

In reply to Re^2: How to push the previous line based on the current line to two different files. by GrandFather
in thread How to push the previous line based on the current line to two different files. by suno

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.