in reply to Re: Removing File Extensions
in thread Removing File Extensions

I applaud your use of a prepackaged module, but I personally think it's a bit overkill in this situation. 

  my @files = qw( foo.zip twotwo.doc three.one.four.ppt four );
  my ( @only_names, @only_exts );
  foreach ( @files )
  {
      if ( m/^ (.*?) (?:\.([^.]+))? $/x )
      {
          push @only_names, $1;
          push @only_exts,  $2; # might be undef
      }
      else
      {
          warn "couldn't parse '$!'";
      }
  }

  # only for debugging output
  foreach ( @only_exts ) { $_ = 'undef' unless defined $_ }

  print "names = [ @only_names ]\n",
        "exts  = [ @only_exts ]\n";

[download]

Which produced: 

  names = [ foo twotwo three.one.four four ]
  exts  = [ zip doc ppt undef ]

[download]

I guess I feel that, since your solution even with a standard module also requires crafting a regex, I'd just as soon write a regex for the whole thing. *shrug*

My main concerns with my solution would be whether the regex is efficient enough — the non-greedy filename part worries me a bit — and the usual "well, you might be able to craft such a regex, but the average programmer..." complaints.

Replies are listed 'Best First'.
Re: Re^2: Removing File Extensions
by dragonchild (Archbishop) on May 02, 2004 at 02:49 UTC
    The point here isn't that either solution would require a regex or not. The goal is to teach someone that the issues one generally runs into have been run into many times before. There is often a wheel that's round enough out there.

    ------
    We are the carpenters and bricklayers of the Information Age.

    Then there are Damian modules.... *sigh* ... that's not about being less-lazy -- that's about being on some really good drugs -- you know, there is no spoon. - flyingmoose

[reply]
      The goal is to teach someone that the issues one generally runs into have been run into many times before. There is often a wheel that's round enough out there.

      I guess our difference in opinion is where draw the line between "simple enough to do 'by hand'" versus "ok, this is hard, let's see if someone else has already done it better".

      I'm not against modules, but I am against unnecessary modules. In this case, as I said, I found the use of a module overkill: instead of having a single regex that did a fairly simple task (and I could comment that regex further, but I didn't think it needed it), I now need to read and understand the documentation for the module. (And, in some cases, install it, make sure it's up to date, etc; File::Basename is a standard module, so that isn't an issue here.)

      I once had a conversation with someone who thought a language (or, at least, a library / API) to generate regexes would be a handy thing to have. I disagreed, seeing as REs are already their own language; learning another one on top of the actual regex seemed unnecessary.

[reply]
        Frankly, using a regex for this is even a little overkill. The easiest solution, for many people, would be to do something like this: 
        my ($base, $ext) = split '.', $filename, 2;

        [download]

        Of course, that fails with filenames that have more than one '.' in them. 

        my ($base, $ext) = map { reverse } split '.', reverse($filename), 2;

        [download]

        Simple! :-)

        ------
        We are the carpenters and bricklayers of the Information Age.

        Then there are Damian modules.... *sigh* ... that's not about being less-lazy -- that's about being on some really good drugs -- you know, there is no spoon. - flyingmoose

[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom