in reply to My excessive and redundant code<333
If it works and it is readable, I wouldn't be too concerned about a few for loops. That said, I'd probably do two things: use hash slices (see perldata) instead of all of the individual $data{key} = $_->key; statements, and pull the guts of the for ( @info ) loop into a subroutine (since you use it twice). For example (untested):
for ( @info ) { push( @loop_data, get_info( $_ ) ); } sub get_info { my ( $info ) = @_; my $sth = $obj->DBI->Replies->sql_count; $sth->execute( $info->id ); my $info->count = ( $sth->fetchrow_array )[0]; my @keys = qw( author content title id date count ); my %data; @data{ @keys } = @$info{ @keys }; return \%data; }
Note: I changed $r to $info->count to clean up the hash slice. Update: Corrected $count to $info->count.
HTH, and congrats on getting it working. That's the first step. :-)
|
---|