Re^3: A refactoring trap

Replies are listed 'Best First'.
Re^4: A refactoring trap by lidden (Curate) on Aug 17, 2005 at 09:53 UTC
No it still works with chomp: `while(chomp (my $line = <DATA>)){` [download] At least with newer perl versions. Tried with perl5.8.6.	[reply] [d/l]
Re^5: A refactoring trap by revdiablo (Prior) on Aug 17, 2005 at 20:11 UTC
No it still works with chomp To understand why this works, take a look at the return value for chomp. Hint: it's not the string with newlines missing. The problem with `while (my $line = <DATA>) {}` is real, it's just obscure. As hinted, it only happens when you get a line with a false value and no newline. Sometimes this happens at the end of a file. Sometimes it happens for other reasons. It usually doesn't cause any actual problems, but certainly is something to look out for.	[reply] [d/l]
Re^6: A refactoring trap by adrianh (Chancellor) on Aug 18, 2005 at 11:46 UTC
The problem with while (my $line = <DATA>) {} is real, it's just obscure ARRRRGH! :-) As has already been pointed out this hasn't been a problem for some time. Perl automatically adds the `defined` for you, as you can easily see by running: `a% perl -MO=Deparse -e 'while (my $line = <DATA>) {}' while (defined(my $line = <DATA>)) { (); } __DATA__ -e syntax OK` [download] This hasn't been a problem for Perl for quite some time, and I wish people wouldn't keep saying it is ;-)	[reply] [d/l] [select]
Re^7: A refactoring trap by revdiablo (Prior) on Aug 18, 2005 at 15:57 UTC
Re^5: A refactoring trap by !1 (Hermit) on Aug 17, 2005 at 18:05 UTC
With this method you'll never be able to loop through the last line.	[reply]