Re^3: out of memory problem

First glance -

add use strict; use warnings to your code then clean up the errors and warnings.
don't use $a or $b as variable names - they are reserved for use by sort
use the three parameter open
where does $fcount in addtoHash get a value? Make it explicit by passing the value into the sub rather than relying on a global.
Don't prototype PrintArray - especially after it's first use!
you probably want chomp @testdataset; before @testdataset = grep { $_ ne '' } @testdataset;
@testdataset = grep { $_ ne '' } @testdataset; is redundant when followed by @testdataset = grep /\S/, @testdataset;
what does for ($mainfile) { achieve?
You test if ($exist == 0), but $i can == 0 and therefore $exist can == 0 (in addtoHash)

You could describe the output you expect. Sometimes knowing what is expected of a piece of code helps understand it - sometimes it helps misunderstand it :)

Update: more items added

DWIM is Perl's answer to Gödel

Comment on Re^3: out of memory problem Select or Download Code

Replies are listed 'Best First'.
Re^4: out of memory problem by perlbeginner10 (Acolyte) on Mar 16, 2006 at 05:33 UTC
The output of the program with the sample dataset I gave in the previous thread is: `cancer-1->breast cancer cancer-1->lung cancer cancer-1->heart cancer cancer-1->stomach cancer cancer-4->foot cancer cancer-1->blood cancer breast cancer-1->foot cancer breast cancer-1->some cancer lung cancer-1->foot cancer lung cancer-2->some cancer lung cancer-1->blood cancer heart cancer-1->foot cancer heart cancer-1->some cancer stomach cancer-1->foot cancer stomach cancer-1->some cancer foot cancer-1->some cancer blood cancer-1->some cancer` [download] As you can see, I am trying to create transitive relationships, ie, If A->B, and B->C, then A->C. But I am also giving weight to the relationships, ie, if A->D, and D->C, then again A->C. So the relation `[valueof{A}][valueof{C}]=2---->`ie 1+1, because the relation was created twice.	[reply] [d/l] [select]
Re^5: out of memory problem by GrandFather (Saint) on Mar 16, 2006 at 07:05 UTC
Now that I understand what you are doing, here's code that generates the output you are looking for, albeit in a different order: use strict; use warnings; my %mappings; while (<DATA>) { chomp; next if ! /\S/; s/^\s+//; s/\s+$//; my ($mainfile, $subfiles) = split /\s,\s/; my @subfiles = split /\s;\s/, $subfiles; @subfiles = grep /\S/, @subfiles; $mappings{$mainfile}{$_} = 1 for @subfiles; } # Generate transitive relationships. ie: if A->B and B->C, then A->C for my $A (keys %mappings) { for my $B (keys %{$mappings{$A}}) { ++$mappings{$A}{$_} for keys %{$mappings{$B}}; } } for my $key (keys %mappings) { print "$key - $mappings{$key}{$_} -> $_\n" for keys %{$mappings{$k +ey}}; } __DATA__ cancer,breast cancer; lung cancer; heart cancer; stomach cancer; breast cancer,foot cancer; foot cancer,some cancer; lung cancer,blood cancer; foot cancer; heart cancer,foot cancer; stomach cancer,foot cancer; blood cancer,some cancer; [download] Prints: lung cancer - 2 -> some cancer lung cancer - 1 -> blood cancer lung cancer - 1 -> foot cancer cancer - 1 -> some cancer cancer - 1 -> lung cancer cancer - 1 -> blood cancer cancer - 1 -> breast cancer cancer - 4 -> foot cancer cancer - 1 -> heart cancer cancer - 1 -> stomach cancer blood cancer - 1 -> some cancer breast cancer - 1 -> some cancer breast cancer - 1 -> foot cancer heart cancer - 1 -> some cancer heart cancer - 1 -> foot cancer foot cancer - 1 -> some cancer stomach cancer - 1 -> some cancer stomach cancer - 1 -> foot cancer [download] DWIM is Perl's answer to Gödel	[reply] [d/l] [select]
Re^6: out of memory problem by perlbeginner10 (Acolyte) on Mar 25, 2006 at 06:38 UTC
Hi GrandFather, Thank you very much for your code. Now I want to increase the weight of transitive relations from ++$mappings{$A}{$_} to $mappings{$A}{$_} = $mappings{$A}{$_} +5. But can you please tell me how to print just the values that are greater than 1? I tried the following: `for my $key (keys %mappings) { if($mappings{$key}{$_} > 1 ) print "$key - $mappings{$key}{$_} -> $_\n" for keys %{$mapping +s{$key}} ; }` [download] But there is this error: `Use of uninitialized value in numeric gt (>) at test.pl line 33, <$tes +tdataset> line 7.` [download] Thanks	[reply] [d/l] [select]
Re^7: out of memory problem by GrandFather (Saint) on Mar 26, 2006 at 05:18 UTC