coldfingertips has asked for the wisdom of the Perl Monks concerning the following question:

At first I thought this would be a MySQL question but oddly enough it's saying I'm not declaring two of my variables (which I can't see how that is).

The errors revolve around 

      my @row;
      my $cnt = -1;
      while(@row = $sth->fetchrow_array)
      {
          $cnt++;
          print "$row[$cnt] test<br>";
      }

[download]
In which its saying 
Global symbol "@row" requires explicit package name at admin.pl line 1
+65.
Global symbol "$cnt" requires explicit package name at admin.pl line 1
+65.
Global symbol "@row" requires explicit package name at admin.pl line 1
+65.
Global symbol "$cnt" requires explicit package name at admin.pl line 1
+65.
Global symbol "@row" requires explicit package name at admin.pl line 1
+65.
Global symbol "$cnt" requires explicit package name at admin.pl line 1
+65.

[download]
However, I am indeed predeclaring both @row and $cnt before the loop even begins. So something else must be wrong and I can't put my finger on it.

Can someone see where I goofed in the code below? 

   if ($action =~ m/upload/i)
   {

      print <<"      EOF";
      <table width="400" border="1" cellspacing="0" bordercolor="#0000
+FF">
        <form action="" method="post" enctype="multipart/form-data">
          <tr>
             <td width="456" height="53"><table width="447" cellspacin
+g="0">
          <tr bgcolor="#FFCCFF">
             <td colspan="2"><div align="center">Upload file to user <
+/div></td>
          </tr>
          <tr>
             <td width="234">File:</td>
             <td width="206"><input name="upload" type="file" id="uplo
+ad"></td>
          </tr>
          <tr>
             <td>User:</td>
             <td><select name="select" MULTIPLE size="5">
      END

      my $data = qq(SELECT username FROM login);

      my $sth = $dbh->prepare($data);
      $sth->execute() or die $sth->errstr;

      my @row;
      my $cnt = -1;
      while(@row = $sth->fetchrow_array)
      {
          $cnt++;
          print "$row[$cnt] test<br>";
      }

      print <<"      EOF";
        </select></td>

      </tr>
      <tr>
        <td colspan="2"><div align="center">
          <input name="UploadFile" type="submit" id="UploadFile" value
+="Upload">
        </div></td>
        </tr>
    </table></table>
      EOF

   }

[download]

Replies are listed 'Best First'.
Re: Problems with sth->fetchrow array or another syntax error
by imp (Priest) on Aug 29, 2006 at 16:51 UTC
    Your first heredoc is 
    print <<"      EOF";
...
END

    [download]
[reply]
[d/l]
      I must say that's rather an embarassing mistake but very nice catch, ++ to you. Thanks!
[reply]

        That is a problem that I pick up as I enter the code into the editor I use with Perl. It is syntax savy and grumbles until I close here docs correctly. It also grumbles about other similar gratuitous syntax fauxpars. Having a Perl syntax savy editor is a great bacon saver!

        DWIM is Perl's answer to Gödel
[reply]

        I stopped using here-docs long ago. qq[ ... ] and similar span lines easily and have other advantages (and some fairly minor disadvantages) but have the significant advantage of not failing in the face of trailing whitespace. Trailing whitespace should never matter, and so here-docs are unacceptably fragile to me. The problems with leading spaces and simple misspelling of the terminator so easily resulting in quite confusing error messages are also good reasons to avoid them. :)

        - tye        

[reply]
[d/l]
        Happy to help.

        Part of the problem you had in diagnosing the problem was because the source code was hard to parse at a glance, which tends to happen when HTML and perl are in the same context.

        I recommend splitting the HTML into a template and using one of the many templating systems that are available. Everyone has their favorite (my favorite is Template Toolkit), but for a first effort I would recommend HTML::Template. You can learn the syntax and be up and running within 30 minutes generally.

[reply]
Re: Problems with sth->fetchrow array or another syntax error
by bart (Canon) on Aug 29, 2006 at 20:09 UTC 
          my @row;
      my $cnt = -1;
      while(@row = $sth->fetchrow_array)
      {
          $cnt++;
          print "$row[$cnt] test<br>";
      }

    [download]
    Why are you displaying a different field for every row? Of course your results will be rather disappointing.

    Besides, you don't bother to html-escape the results. There might be special characters or substrings for html, in the database fields, and the result might even be invalid html.

[reply]
[d/l]

Back to Seekers of Perl Wisdom