in reply to Re^3: Parsing command line options without knowing what they are
in thread Parsing command line options without knowing what they are

Nice. Especially nice since I've been doing alot of refactoring like this the last few weeks on code written by much less experienced Perl programmers. I'm curious about this line, though: 
            next unless defined $first;

[download]
I don't think it's ever possible for $first to be undefined. If the regex in your if matches, the first capture will always have to be one character long, right? Never undefined?

--DrWhy

"If God had meant for us to think for ourselves he would have given us brains. Oh, wait..."

Replies are listed 'Best First'.
Re^5: Parsing command line options without knowing what they are
by BrowserUk (Patriarch) on Nov 25, 2010 at 20:59 UTC
    I don't think it's ever possible for $first to be undefined

    You're right of course++

    My only excuse is that it is an artifact of the iterative development process I went through as I tried to handle each different case. I think the test made sense at some point; but then again, maybe not :)

    During the refactoring, I just attempted to remove some levels of nesting by moving things around, without breaking anything. I didn't actually consider why each condition was there at that point. It just highlights the value of peer review :)

    Examine what is said, not who speaks -- Silence betokens consent -- Love the truth but pardon error.
    "Science is about questioning the status quo. Questioning authority".
    In the absence of evidence, opinion is indistinguishable from prejudice.
[reply]

In Section Seekers of Perl Wisdom