in reply to Re: Sorting Unique
in thread Sorting Unique

I tryed the code and it did not worked, it was empty. This is the code: 
#!/usr/bin/perl

print "Please enter the file name you want the word count\n\n";
$file= <STIDN>;
chomp $file;


$file=<STDIN>;
chomp $file;

open(FILE, $file) or die $!;

my %u_wc;
while (<FILE>){
        my @words= split;
        $words += @words;
        $u_wc{$_}++ for @words;
}
print ("The number of words in the file is $words\n\n");
print ("this are the unique words $u_wc\n\n");

[download]

Replies are listed 'Best First'.
Re^3: Sorting Unique
by ww (Archbishop) on Aug 19, 2011 at 04:30 UTC
    Look again at lines 4-5 and 8-9. In one case, you have a spelling error...so the only thing saving you is the existence of the second pair, which would be redundant were the first caught and corrected.

    Perhaps you've posted code that is not be what you've actually written. Try to post with cut'n'paste, to avoid such problems.

    And whether or not what's shown is your actual code, use strict;, use warnings, as they will alert you to problems with your variables, such as:

    Global symbol "$file" requires explicit package name at F:\_Perl_\pl_test\921134.pl line 7. (your line 4)

    Fixing those and rerunning would have allowed strict and warnings to point out additional syntax errors (not including the grammatical error in your print statement at your line 20). When you've dealt with those, you'll be free to concentrate on the logic.

    You've already been alerted (by other Monks) to some of your logical problems; you've added to them and need to further your understanding of hashes.

[reply]
[d/l]
[select]
Re^3: Sorting Unique
by muba (Priest) on Aug 19, 2011 at 04:05 UTC 
    # As suggested by toolic above
use strict;
use warnings;



print "Please enter the file name you want the word count\n\n";
my $file= <STDIN>;

chomp $file;


# Lexical file handles (my $fh) are better than file globs.
# Also, three-argument open() is better than two-argument open().
open(my $fh, "<", $file) or die $!;

my %u_wc;
my $words = 0;             # Don't forget to declare $word!
while (<$fh>){
        my @words = split;
        $words += @words;
        $u_wc{$_}++ for @words;
}

# print ("The number of words in the file is $words\n\n");
# The parens are useless here, and also inconsistent with the print st
+atement
# that prompted us for a file name.
print "The number of words in the file is $words\n\n";

# print ("this are the unique words $u_wc\n\n");
# $u_wc isn't a variable. We do have %u_wc though.

print "These are the unique words: ", join(" ", keys %u_wc), "\n\n";

    [download]

    Output:

    G:\abyss>perl x.pl
Please enter the file name you want the word count

x.pl
The number of words in the file is 150

These are the unique words: want you file that useless my print parens
+ statement
 better $file= suggested also unique strict; $file; name words: warnin
+gs; "These
 with and number of do += die is %u_wc 0; to have open(my $u_wc "The %
+u_wc), her
e, $!; <STDIN>; # "\n\n"; Lexical isn't $words\n\n"; $file) "<", $u_wc
+\n\n"); }
two-argument the variable. open() a = @words toolic ("The @words; or i
+n As split
; $u_wc{$_}++ name. $words\n\n"); $words for enter by prompted inconsi
+stent We w
ord declare %u_wc; The $fh) Don't $word! join(" are globs. forget word
+s keys ("t
his handles count\n\n"; use above us ", though. open(). than $fh, (<$f
+h>){ (my w
hile chomp Also, "Please three-argument


G:\abyss>

    [download]
[reply]
[d/l]
[select]
      Ok but what I needed what the count of the unique words, not the actual unique words. By the way thanks all you perlmonks you guys are helping me big time
[reply]

        Fair enough.

        You could go with 

        while ( my ($word,$count) = each %u_wc) {
    print "$word: $count\n"
}

        [download]

        Or you could go with print "$_: $u_wc{$_}\n" for keys %u_wc;. And there are many other ways but these will suffice.

[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom