Do i need to use lock $hash{foo} ; or lock ( \%hash ) ; if foo is used as shared_clone ?

my %h : shared;
$h{foo} = share ({});
...
$h{foo}{bar} = 1; # in thread 1
$h{foo}{bar} = 2; # in thread 2
[download]

Dave.

1. Do i need to use lock $hash{foo} ; or lock ( \%hash ) ; if foo is used as shared_clone ?

It depends upon what you intend to modify.

When you have nested hashes so:

%hash :shared = &share( {} );
[download]

1. To add a new key/value pair; or delete a key/value pair; or modify the value associated with an existing key in %hash you need:

   lock %hash;
   $hash{ existingkey } = newvalue;
   # or
   $hash{ newkey } = newvalue;
   #or 
   delete $hash{ existingkey };
   [download]

2. To modify the nested anonymous hash associated with the key 'foo', you need:

   lock %{ $hash{ foo } };
   $hash{foo}{somekey} = somevalue;
   # or
   delete $hash{ foo }{ somekey };
   [download]

   Ie. lock %{ $h{1} } says lock the hash referenced by the value at $h{1}.

I did, it seems to work. I am however, wary of corner cases, when threads are involved.

I did, it seems to work

That's strange, because for me it didn't work:

use threads;
use threads::shared;

my %sa : shared = ();
%{$sa{foo}} = ();
__END__
Invalid value for shared scalar at share_share.pl line 5.
[download]