in reply to Re^4: LeetCode Problem #1 - Two Sum - Improve and/or discuss.
in thread LeetCode Problem #1 - Two Sum - Improve and/or discuss.

Hi Ken

> Please post whatever parts of the code you'd write differently. 

my @tests = (
    [[2,7,11,15], 9, [0,1]],
    [[3,2,4], 6, [1,2]],
    [[3,3], 6, [0,1]],
);

for my $test (@tests) {
    is_deeply
        sort_arrayref(two_sum($test->[INPUT], $test->[TARGET])),
        $test->[EXPECTED];
}

sub sort_arrayref {
    my ($aref) = @_;

    return [ sort { $a <=> $b } @$aref ];
}

[download]

hope it's clearer now :)

Cheers Rolf
(addicted to the Perl Programming Language :)
Wikisyntax for the Monastery

Replies are listed 'Best First'.
Re^6: LeetCode Problem #1 - Two Sum - Improve and/or discuss.
by kcott (Archbishop) on Jan 24, 2022 at 21:36 UTC
[reply]
[d/l]
[select]
      > By the way, I don't see any difference between my &sort_arrayref and yours. I've looked closely at both; do let me know if I've missed something.

      They are the same.

      > You've modified is_deeply such that any additional tests added to @tests must have the results in ascending order for the is_deeply test to be successful.

      OK, if you prefer to order them during the tests, so be it.

      > There were no duplicates. I added (different) tests such that the result could be in "any order".

      hmm ... those seemingly different "any order" arrays are sorted to the same expect-part in the tests.

      Hence half of your tests are redundant and violate the DRY principle.

      I really don't know how to explain it any better.

      FWIW: one actually needs more tests if the input isn't unique, since those cases are different but legit solutions.

          [[2,7,7,15], 9, [0,1]],
    [[2,7,7,15], 9, [0,2]],

      [download]

      another case for multiple solutions would be 

          [[2,7,4,5], 9, [0,1]],
    [[2,7,4,5], 9, [2,3]],

      [download]

      Cheers Rolf
      (addicted to the Perl Programming Language :)
      Wikisyntax for the Monastery

[reply]
[d/l]
[select]

        Consider if a new element is added to @tests: 

        [[1,2,3,6], 5, [2,1]]

        [download]

        So, 3+2=5 and the solution is found. In my code, with a sorted $test->[EXPECTED], the test passes; in yours, with an unsorted $test->[EXPECTED], the test fails.

        "FWIW: one actually needs more tests if the input isn't unique, since those cases are different but legit solutions. ... another case for multiple solutions would be ..."

        That's incorrect. The spec has, in emboldened text (under Contraints): Only one valid answer exists.

        — Ken

[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom