Re^3: Compare 2 arrays

Please re-read my post at Re^2: Compare 2 arrays. This does take into account the *.nfo files in the SDF file. The code from stevieb can also be adjusted to do this. The Monks expect that you spend some time analyzing and understanding the code that is being written for you. You have a couple of approaches and both will work.

Test in small increments. For example to parse the SDF file, you could break out my code into a short test program like this:

#!/usr/bin/perl
use strict;
use warnings;
use Data::Dumper;


my %keepList;

while (my $line = <DATA>) 
{
   my $sdf_file;
   next unless ($sdf_file) = $line =~ /(\w+\.nfo)/;
   $keepList{$sdf_file} = 1;
   print "keeping $sdf_file\n"; #update for debugging #######
}

=example printout
keeping filename1.nfo
keeping filename2.nfo
=cut

__DATA__
fullpath="C:\directory\filename1.nfo"
id="1a"
fullpath="C:\directory\filename2.nfo"
[download]

As a note: If you are using Windows file names with a space in them, then the regex would be different. I only use filenames that are compatible with both Unix and Windows and that is probably the case here, but it may not be. One reason to run a simple test on the actual file!

update: I should clarify, when you have a choice, use only [a-zA-Z0-9_], in the file names, basically anything that meets the rules of a valid identifier in Perl or C is fine, what Perl calls \w characters. Forgo using spaces or dashes in the names if you can and your life will be easier.

Comment on Re^3: Compare 2 arrays Select or Download Code

Replies are listed 'Best First'.
Re^4: Compare 2 arrays by niceguy (Initiate) on Jun 29, 2016 at 22:10 UTC
Hi Marshall, Thanks! That does work! With the help of my co-worker, we refined it a little more by including white spaces in search. Thank you all who have helped me with my problem. Below is what we came up with. #!\perl\bin\perl use strict; use warnings; my $files = "C:/Directory"; my $list = "C:/Test.sdf"; open my $name, '<', $list or die "Failed to open file: $!\n"; my @files = $files; opendir(OUTPUT, $files); @files = grep {$_ ne '.' and $_ ne '..'} readdir(OUTPUT); closedir(OUTPUT); my %wanted_files; while (<$name>) { if ($_ =~ /^\sfullpath=.[\\\/](\w+\.nfo)"/) { $wanted_files{$1} = 1; } } foreach my $target_file (@files) { if (not $wanted_files{$target_file}) { unlink($files . "/" . $target_file) or die $!; } } [download]	[reply] [d/l]
Re^5: Compare 2 arrays by Marshall (Canon) on Jun 30, 2016 at 00:01 UTC
Did you actually test that your regex would deal with spaces in the file name? I think not. `\w+` will not match a space, only `[0-9a-zA-Z_]`. A demo of different regex: #!/usr/bin/perl use strict; use warnings; use Data::Dumper; my %keepList; while (my $line = <DATA>) { my $sdf_file; next unless ($sdf_file) = $line =~ /([\w ]+\.nfo)/; $keepList{$sdf_file} = 1; print "keeping \"$sdf_file\"\n"; #update for debugging ####### } =example printout keeping "filename1.nfo" keeping "filename2.nfo" keeping "file name2.nfo" keeping "file name3.nfo" keeping "file name4.nfo" =cut __DATA__ fullpath="C:\directory\filename1.nfo" id="1a" fullpath="C:\directory\filename2.nfo" id = "nonsense" fullpath = "C:\directory\file name2.nfo" fullpath = "C:/directory/file name3.nfo" fullpath = "C:\directory/file name4.nfo" [download] Your code: `my @files = $files; opendir(OUTPUT, $files); @files = grep {$_ ne '.' and $_ ne '..'} readdir(OUTPUT); closedir(OUTPUT);` [download] better written? as: `opendir(OUTPUT, $files) or die "unable to opendir $!"; my @files = grep {-f $files/$_} readdir(OUTPUT); closedir(OUTPUT);` [download] The -f file test excludes not only the "." and ".." directories but also other ones that might exist. `my @files = $files;` does nothing useful. Overall, great job at getting something to "work". In the scheme of things, my comments are just nits.	[reply] [d/l] [select]
Re^6: Compare 2 arrays by Anonymous Monk on Jul 01, 2016 at 17:43 UTC
Hi Marshall, Thank you for pointing out my shortsigned. I will use your code for opening the directory, and I will remove the useless "`my @files = $files`" statement. Regarding the spaces in the file name, we don't have that problem because all the file name does not have any spaces, that is our procedure for this contents. Thank you again for your help, much appreciated.	[reply] [d/l]