in reply to Embedded function or subroutine - which is better?

I don't know how perl pre-parses code on the fly - is it quicker (i.e. will perl map out a call to a sub-routine on pre-parse) such as
if ($debug == "true") { &debugit; # call the routine }
or
if ($debug == "true") { ** do all the debug code here and/or carry on ** }

Premature optimization. Keep the code readable and maintainable. If you need the debug code more than once, put it in a function. If the debug code spans more than a few lines, do the same. For a single, simple print, wrap it directly in the if block.

Oh, and by the way: Omit the ampersand in function calls. It is perl4-style and does not do what you expect. See also Re^2: Merge log files causing Out of Memory (just a note on ampersand).

Another update: $debug == "true" does not do what you want. == is for numeric compares, eq is for string compares. (how to remember that). But you don't want either, use Perl's native booleans: In boolean context, scalars that are undefined (undef), the empty string ("") or the number zero (0) evaluate as false, any other value evaluates as false true. Commonly, you would use the value 1. So:

my $debug=1; # or $debug='' to disable # later: if ($debug) { debugIt(); }

Alexander

--
Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)

Replies are listed 'Best First'.
Re^2: Embedded function or subroutine - which is better?
by Linicks (Scribe) on Aug 27, 2016 at 17:31 UTC

    Blimey!, as we say here in England.

    I just re-read about sub routines in my Camel book, and have never ever heard about omitting the & - just a 'subroutine();' does it!

    I just changed my code to have a sub debug; and it works great and seems more fluid!

    Many thanks for your wisdom!

    Regards, Nick

    P.S. sorry, was replying then saw your update - the '==' was a mistake by me just typing in from a bad memory - should be 'eq' of course!

Re^2: Embedded function or subroutine - which is better?
by Linicks (Scribe) on Aug 27, 2016 at 17:52 UTC

    Thanks again. The line '$debug eq "true"' is a must as it comes from a HTML form and can have different string values, so a match is needed.

    Nick