in reply to Re: File deletion
in thread File deletion

Except it sounds like you want to delete everything BUT the contents of the array.

my %keep; @keep{@files} = 1; # populate a lookup hash foreach my $file ( @filelist ) { unlink $file unless exists( $keep{$file} ); }

Replies are listed 'Best First'.
Re: Re: Re: File deletion
by converter (Priest) on Nov 01, 2002 at 06:06 UTC

    There's one minor problem with your example: your hash slice assignment creates the expected keys, so exists will work, but since you're assigning only one value to the slice, only the hash element with the key corresponding to the first element in @files will have a value (1), the rest will have the undefined value. This could lead to confusion (i.e. code that mysteriously refuses to work the way you expect it to) later on should you be required to make any changes that assume that each element of the hash has the value 1.

    It would probably be best to either assign an empty list to the hash slice, which would give you a key for each filename in @files for use with exists, or to assign a list of true values with the same number of elements as the @files array using the repetition operator x.

    @keep{@files} = (); # empty list @keep{@files} = (1) x @files; # list of "TRUE" values
    With the latter assignment, you could modify the code to check the value of the hash element, instead of the key:
    @keep{@files} = (1) x @files; foreach my $file ( @filelist ) { unlink $file unless $keep{$file}; }

      ... and you should be testing the return value of unlink since it can fail :-)

      Something like this should work (untested code):

      @keep{@files} = (1) x @files; foreach my $file ( @filelist ) { next unless $keep{$file}; unlink $file == 1 or warn "could not unlink $file ($!)\n"; }

      (yes, I know that you could just test unlink for truth/false in this instance - but I always like to remind myself that it returns the number of successful deletions rather than success/failure).

Re: Re: Re: File deletion
by Three (Pilgrim) on Nov 01, 2002 at 23:14 UTC
    I think it would be a whole lot easier to get a hash of the files in the directory. Then delete the files to be saved out of the hash? And then unlink all files in the hash? ex.
    my %trash; @trash{@file_list} = " "; delete @trash{@saved_files}; foreach $file (keys %trash) { unlink $file; }
    Tell me if I am wrong but woulnt it be a bit faster because you are not doing a conditional check in the loop?
    Three
Re: Re: Re: File deletion
by cored (Scribe) on Nov 01, 2002 at 16:16 UTC
    But, this will erase the file that is in the hd right ?