Any help will be greatly appreciated.

I'll help format it so it is at least readable.

my $x      = 0;
my $numpix = @data;
    
while ($data[$x]) {
    my ($i, @orderdata, %myhash);

    foreach $i (1 .. $x) {
        if ($i == $data[$x]{'picorder'}) {
            $myhash{'orderline'} = "<option value=\"$i\" selected>$i</
+option>";
        } else {
            $myhash{'orderline'} = "<option value=\"$i\" selected>$i</
+option>";
        }
        push (@orderdata, \%myhash);    
    }

    $data[$x]{'orderdata'} = \@orderdata;

    if ($data[$x]{'anaglyph'} eq "Yes") {
        $data[$x]{'anaglyph'} = "checked";
    }

    $x++;
}
[download]

I don't see the error though.

-sauoq
"My two cents aren't worth a dime.";

    while($db->FetchRow()){                
        my %hash = $db->DataHash(@$fields_ref);
        push (@data, \%hash);
    }
[download]

    while($db->FetchRow()){                
        push (@data, $db->DataHash(@$fields_ref));
    }
[download]

    while ($data[$x]){
        my ($i,@orderdata,%myhash);
        foreach $i (1 .. $numpix){
            if ($i == $data[$x]{'picorder'}){
$myhash{'orderline'} = "<option value=\"$i\" selected>$i</option>";
                }else{
$myhash{'orderline'} = "<option value=\"$i\" selected>$i</option>";}
            push (@orderdata, \%myhash);    
        }
        $data[$x]{'orderdata'} = \@orderdata;
        #transform anaglyph data for checkboxes
        if ($data[$x]{'anaglyph'} eq "Yes"){
$data[$x]{'anaglyph'}="checked";}
        $x++;
    }
[download]

concerning the one-liner, this should work:

while($db->FetchRow()){                
   push @data, { $db->DataHash(@$fields_ref) };
}
[download]

By using the curlies you are creating an anonymous hash reference out of the hash returned by the DataHash method which is directly pushed onto @data.

-- Hofmator

Update:Ignore this! Its a complete red-herring bought about by brain-fade.

if ($data[$x]->{'anaglyph'} eq "Yes"){
    $data[$x]->{'anaglyph'}="checked";
}
[download]

To clarify: If the array element $data[$x] contains a valid reference to a hash, then you need dereference that using -> to indicate that this is the case.

To clarify: If the array element $data[$x] contains a valid reference to a hash, then you need dereference that using -> to indicate that this is the case.

No, you don't need to do so.

my %h = ( foo => 'bar' );
my @a = ( \%h );
print "worked fine\n" if $a[0]{foo} eq 'bar';
[download]

You need to use the arrow when you are dealing directly with a scalar containing a reference rather than a nested one.

my %h = ( foo => 'bar' ); 
my @a = ( \%h ); 
my $r = \@a; 
print $r->[0]{foo}, "\n"; # $r[0] won't work since @r doesn't exist.
[download]

-sauoq
"My two cents aren't worth a dime.";

You're looping $i 1 through $x but you're also incrementing $x! When will this loop ever end? (After carefully matching braces, I see that I was mistaken.)

Your data structure is very complex. You're trying to create an Array of Hashes of Arrays of Hashes? Or am I reading this wrong?

If I understand you correctly you expect

  my $x = 10;
  for my $i (1 .. $x) {
    $x = 1;
    print $i;
  }
[download]

to execute only once. That would be the case if the above was equivalent to

  my $x = 10;
  for (my $i = 1; $i <= $x; $i++) {
    $x = 1;
    print $i;
  }
[download]

, but it isn't. Recall that the non-C-style for (aka foreach) is a list iterator. 1 .. $x is a list. Compare with   my @foo = 1 .. $x; If you'd now do   foreach (@foo) { ... } you wouldn't expect foreach to act any differently upon modification of $x.

(Afaik for (EXPR .. EXPR) is nowadays optimized to not build a list, but that's irrelevant from a language point of view.)

Hope I've helped,
ihb

The final data structure is an array of hashes. In each hash is another array of hashes (each hash having only one key/value pair).