in reply to Re: Re: Updating Specific Fields in MS Access
in thread Updating Specific Fields in MS Access

Your almost there but, there is a problem with your SQL statement (it is not valid). The statement should be something like:
my $sqlstatement=("UPDATE servers SET nicl_driver_version = '$driver' 
+WHERE '$field1' = '$servlist'");

[download]
So you need to put single quotes around $driver as it is not all numeric, nor the SQL keyword NULL, I have also changed you WHERE clause to reflect what I think you want it to do. One good resource for SQL syntax is w3schools

you also don't appear to be using $field2 or $vals for anything, and don't need the use Win32::ODBC; line for anything as well (you are not using that module in your code at all).

One last thing is that you might want to prepare your SQL statement outside your loop, and then execute it on the inside, so you don't have to prepare the same statement time and time again unnecessarily). So your code might look something like this(untested):

use DBI;
use strict;

my $DSN='Database';
my $field1 = 'Server';

my $dbh=DBI->connect("dbi:ODBC:$DSN", "admin", "") 
   or die "$DBI::errstr\n";

my $sth = $dbh->prepare(
   "UPDATE Servers 
    SET nic1_driver_version= ? 
    WHERE '$field1' = ?" );

#Open file for reading
open(INPUT,"file.txt") || die;
while (<INPUT>) {
 chomp;
 my ($servlist, $driver)=split(/,/);
 $sth->execute($driver,$servlist) or die;
}
close (INPUT);
$dbh->disconnect;

[download]
update:added line to script because I neglected to initialize $field1 (so that line is now there), which would be the reason for the failure, p01p0t was having in Re: Re: Re: Re: Updating Specific Fields in MS Access

-enlil

Replies are listed 'Best First'.
Re: Re: Re: Re: Updating Specific Fields in MS Access
by p0lp0t (Initiate) on Apr 17, 2003 at 23:36 UTC
    Your response is appreciated.

    When I try to place the prepare before the loop, it complains about uninitialized values.
    I tried using placeholders, to no avail, so I kept the prepare in the loop. Now I have:

    #! C:\perl\bin\perl.exe -w

use DBI;
#use strict;

my $DSN='Database';
my $driver;
my $servlist;
my $field='Server';

#connect to database
my $dbh=DBI->connect("dbi:ODBC:$DSN", "admin", "") || die;

#Open file for reading
open(INPUT,"file.txt") || die;
while (<INPUT>)
    {
    chomp;
    my ($servlist, $driver)=split(/,/);
    my $sqlstatement=("UPDATE Servers SET nic1_driver_version='$driver
+' WHERE '$field' = '$servlist\n'");
    my $sth=$dbh->prepare($sqlstatement);
    $sth->execute || die;
    }
close (INPUT);
$dbh->disconnect;

    [download]
    Spits back:
    DBD::ODBC::st execute failed: MicrosoftODBC Microsoft Access Driver Too few parameters. Expected 1. (SQL-07002)(DBD: st_execute/SQLExecute err=-1) at C:\Perl\scripts\test\newer.pl line 22, <INPUT> line 1.
    Died at C:\Perl\scripts\test\newer.pl line 22, <INPUT> line 1.

    I am confused about the parameters error.
    Regards,
    jw
[reply]
[d/l]

      In order to use placeholders, put a '?' whereever you will need to plug data into the statement. Your UPDATE statement then becomes:

      my $sth = $dbh->prepare("UPDATE Servers SET nic1_driver_version=? WHER
+E Server=?");

      [download]

      Then, pass the values to plug into those placeholders to execute like so:

      $sth->execute($driver,$servlist);

      [download]

      The statement doesn't need to change from one execution of the loop to the next. Therefore, the prepare can be done outside the loop. The values change each iteration and get plugged into the statement at execute time inside the loop.

      90% of every Perl application is already written. ⇒
      dragonchild
[reply]
[d/l]
[select]
        I now have: 
        #! C:\perl\bin\perl.exe -w

use DBI;
#use strict;

my $DSN='Database';
my $driver;
my $servlist;

#connect to database
my $dbh=DBI->connect("dbi:ODBC:$DSN", "admin", "") || die;
my $sqlstatement=("UPDATE Servers SET Servers.nic1_driver_version=? WH
+ERE server=?");
my $sth=$dbh->prepare($sqlstatement);

#Open file for reading
open(INPUT,"file.txt") || die;
while (<INPUT>)
    {
    chomp;
    my ($servlist, $driver)=split(/,/);
    $sth->execute ($driver,$servlist) || die;
    }
close (INPUT);
$dbh->disconnect;

        [download]
        but still get:

        DBD::ODBC::st execute failed: Microsoft ODBC Microsoft Access Driver Too few parameters. Expected 3. (SQL-07002)(DBD: st_execute/SQLExecute err=-1) at C:\Perl\scripts\test\newer.pl line 21, <INPUT> line 1.
        Died at C:\Perl\scripts\test\newer.pl line 21, <INPUT> line 1.

        Thanks again,
        jw
[reply]
[d/l]

In Section Seekers of Perl Wisdom