in reply to Copy and Rename file at destination directory

instead of 
copy( "$dir\\$file", "C:\\testfiles\\$file" )
          or die "Failed to copy $file: $!\n";
    rename $file, $newfile

[download]
You should try: 
copy( "$dir\\$file", "C:\\testfiles\\$file" )
          or die "Failed to copy $file: $!\n";
    rename "C:\\testfiles\\$file", "C:\\testfiles\\$newfile";

[download]
But have you ever tried this: 
copy( "$dir\\$file", "C:\\testfiles\\$newfile" )
          or die "Failed to copy $file: $!\n";

[download]
Question: What will happen if you copy more than one file from $dir?

Answer: You will end up with just one $newfile.

Then regarding your not-shifted $newfile parameter to your sub. Instead of shifting a sub's parameters I prefer to write: 

sub process_dir {
    my ($dir, $newfile) = @_;

[download]

Replies are listed 'Best First'.
Re: Re: Copy and Rename file at destination directory
by Skyler99 (Novice) on Jun 04, 2003 at 12:36 UTC
    Dear Monk I try to compiled the code but it gave me an error. I put a print statement before the next statements so I could get an accurate result on what the script is doing. This is the error : 
    dir: C:\Apps\Impac\Db\Escribe\07\00002A0F.002 file: newfile:270917
dir: C:\Apps\Impac\Db\Escribe\07\00002A0F.002 file:STATUS.TXT newfile:
+270917
dir: C:\Apps\Impac\Db\Escribe\07\00002A0F.002 file:WORD1.RTF newfile:2
+70917

Failed to copy Word1.rtf: No such file or directory

    [download]
    I'm trying to copy the RTF file and not the TEXT . I cannot tell if the script is getting mix up with trying to rename the RTF and TEXT. Could you take a look at the code and let me know if I need to change anything to make it work. Thanks in advance 
    #! perl -w

use strict;
use File::Copy;

my $infile = "c:/zip files misc/doclisth.chr";
open IN, "<$infile" or die "Couldn't open $infile, $!";
while (<IN>) {
    chomp;
    my @fields   = split /,/;

    my $newfile = $fields[0];
    my $path_str = $fields[13];

    do { warn "Empty field 14"; next } unless $path_str;
    my @path = split /\\/, $path_str;
    my $dir = join "\\", @path[ 0, 1, 2, 3, 4, 5, 6 ];

    process_dir($dir,$newfile);
}
close IN;

sub process_dir {

    my ($dir, $newfile) = @_;

    do { warn "$dir does not exist!\n"; return } unless -e $dir;
    opendir DIR, $dir or do { warn "Could not open $dir $!\n" ; return
};
    while ( my $file = readdir DIR ) {

        print "dir: $dir file:$file newfile:$newfile\n";
        #before the next unless statements.

        next unless -f "$dir\\$file";
        next unless $file =~ m/\.rtf$/;


        copy( "$dir\\$file", "C:\\testfiles\\$newfile" )
          or die "Failed to copy $file: $!\n";

    }
}

    [download]
[reply]
[d/l]
[select]
      If I might make a suggestion, try stripping everything down so that you are just running the copy() and explicitly give it path/filenames. Then work backwards from there.

      "Ex libris un peut de tout"

[reply]

In Section Seekers of Perl Wisdom