• Your dbh setup looks overly complicated. Could you explain why you couldn't do something like:

  my $dbh = DBI->connect(
      $connect_string,
      $user,
      $pass,
  );
  
  die "Couldn't connect to DBI\n" unless $dbh;
  $dbh->{RaiseError} = 1;
  [download]

• Whenever I see a bunch of variables defined at the top, I cringe. Having one or two globals ... I can see. These would be things along the lines of $dbh and the like. 12 is a little much.
• Why does everyone need to know about $even? It's used in exactly two places. In fact, you calculate it in one place, then use the result in another. Why not just calculate it in the place you use it? At least, calculate it in the function you use it ...
• You don't check the return result of $dbh->prepare(), even though you're passing it a dynamically-generated SQL statement. You also don't call $sth->finish(). This isn't a problem, until you use prepare_cached(). It's just a good habit to get into.
• You can do the following type of replacement in a lot of places:

  for ( my $i = 0; $i < scalar(@mini) ; $i++ )
  {
      delete $mini[$i]{'MajorDescription'};
      delete $mini[$i]{'MajorKey'};
      delete $mini[$i]{'hits'};
  }
  
  ----
  
  foreach my $i (0 .. $#mini)
  {
      delete $mini[$i]{$_}
          for qw(MajorDescription MajorKey hits);
  }
  [download]

------
We are the carpenters and bricklayers of the Information Age.

The idea is a little like C++ templates, except not quite so brain-meltingly complicated. -- TheDamian, Exegesis 6

Please remember that I'm crufty and crochety. All opinions are purely mine and all code is untested, unless otherwise specified.

You also don't call $sth->finish(). This isn't a problem, until you use prepare_cached().

Why would it be a problem then? He uses fetchall_*.

It's a good habit to get into, imho. Most times, you can omit the finish(), but sometimes it will bite you in the ass. Adding the finish() call never hurts, so I always do it.

------
We are the carpenters and bricklayers of the Information Age.

The idea is a little like C++ templates, except not quite so brain-meltingly complicated. -- TheDamian, Exegesis 6

Please remember that I'm crufty and crochety. All opinions are purely mine and all code is untested, unless otherwise specified.

Update: Whoops! I just posted step by step instructions on how to hack into your box. Then I realized you posted the URL. I have taken the post down until you fix the security hole. In the event that you don't see this, I've sent email to the address listed on the error page I generated. You can also email me for details at poec at yahoo dot com. I will repost the details after this hole is plugged.

Cheers,
Ovid

New address of my CGI Course.

for ( my $i = scalar(@$results) - 1; $i >= 0; $i-- ){
 for ( my $j = 1; $j <= $i; $j++){
  if ( $$results[$j - 1]{'hits'} < $$results[$j]{'hits'} ){
      my $temp = $$results[$j - 1];
      $$results[$j - 1] = $$results[$j];
      $$results[$j] = $temp;
   }
 }
}
[download]

@$results = sort{ $b->{'hits'} <=> $a->{'hits'} } @$results;
[download]

my $temp = $$results[$j - 1];
$$results[$j - 1] = $$results[$j];
$$results[$j] = $temp;
[download]

($$results[$j - 1], $$results[$j]) = ($$results[$j],$$results[$j - 1])
[download]

Though there might be more things this just stuck out at me as more a C type thing than a Perl type thing

-enlil

Where you have:

    my $onlyonce = 1;
    foreach my $tempword ( @words )
    {
        if ( $onlyonce == 1 )
        {
            $searchstring .= "MajorDescription LIKE '%$tempword%' OR M
+ajorName LIKE '%$tempword%'";
            $onlyonce = 0;
        }
        else
        {
            $searchstring .= " OR MajorDescription LIKE '%$tempword%' 
+OR MajorName LIKE '%$tempword%
+'";
        }
    }
[download]

Why not replace all of that with:

    $searchstring=join " OR ",
                  map "MajorDescription LIKE '\%$_\%' OR MajorName LIK
+E '\%$_\%'",
                  @words;
[download]

If you don't like join/map, may I suggest this alternative?

    my $or="";
    foreach my $tempword ( @words )
    {
        $searchstring .= " $or MajorDescription LIKE '%$tempword%' OR 
+MajorName LIKE '%$tempword%'";
        # only set this once
        $or="OR" unless $or;
    }
[download]

The lack of $dbh->disconnect is a potential disaster waiting to happen. Don't know what the SQL server defaults are but by default MySQL will accept 100 connections that will persist for 8 hours. Although it surprised me undefing $dbh (ie when the script finishes) does not cause a DESTROY{ ..disconnect .. ) to be called allowing the connections to persist and accumulate.....until it falls over with a too many connections error. This particular error often goes unnoticed until you get real load on a widget.

One way to code it to make sure this does not happen is

my $sth;
my $dbh->connect(......
END{ $sth->finish if $sth; $dbh->disconnect if $dbh }

# now do whatever
[download]

cheers

tachyon

s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print

If ruhk is running mod_perl under Apache, this isn't a problem - the DBI connect method will default to Apache::DBI::connect which keeps persistent connections (in this case, disconnect is overloaded and will not disconnect). If this is a CGI, connect_cached should be used - a persistent connection would be appropriate for this application. However, disconnect-ing doesn't hurt and is good form...

Actually if you use this syntax you will pile up persistent connections under mod_perl. Trust me. We have done it. In production. Disconnecting is much more than good form.....

my $dbh = DBI->connect...
[download]

The connection is as you say persistent. This is immaterial. This will pile connections up running under mod_perl/vanilla/or off the command line. The my means that the handle to the connection disappears every time you re-exec your script (effectively a sub). The connection however remains.....

If you don't believe me put it in a loop and you will quickly bring your DB to its knees.

cheers

tachyon

s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print