in reply to Search engine code critique

A few thoughts:

------
We are the carpenters and bricklayers of the Information Age.

The idea is a little like C++ templates, except not quite so brain-meltingly complicated. -- TheDamian, Exegesis 6

Please remember that I'm crufty and crochety. All opinions are purely mine and all code is untested, unless otherwise specified.

Replies are listed 'Best First'.
Re: Re: Search engine code critique
by chromatic (Archbishop) on Sep 18, 2003 at 20:01 UTC
    You also don't call $sth->finish(). This isn't a problem, until you use prepare_cached().

    Why would it be a problem then? He uses fetchall_*.

      It's a good habit to get into, imho. Most times, you can omit the finish(), but sometimes it will bite you in the ass. Adding the finish() call never hurts, so I always do it.

      ------
      We are the carpenters and bricklayers of the Information Age.

      The idea is a little like C++ templates, except not quite so brain-meltingly complicated. -- TheDamian, Exegesis 6

      Please remember that I'm crufty and crochety. All opinions are purely mine and all code is untested, unless otherwise specified.

        lack of finish is trivial compared to lack of disconnect - also missing. Disconnect will force finish on any open sth (albeit generating warnings). but not disconnecting is really bad

        cheers

        tachyon

        s&&rsenoyhcatreve&&&s&n.+t&"$'$`$\"$\&"&ee&&y&srve&&d&&print