I can see 2 problems. Your XML does not have an element named "href". You need to change elements named "subfield". Your regex is incorrect: 
my $twig = XML::Twig->new(
    twig_handlers   => { subfield => \&editHref, },
    pretty_print    => 'indented',
);

$twig->parse($xml);
$twig->print;

sub editHref {
    my ( $twig, $href ) = @_;
    my $text = $href->text();
    my $orig = "(OSt)16";
    $text =~ s/\Q$orig/(OSt)20/;
    $href->set_text($text);
}

[download]

Or, just avoid the regex... 

sub editHref {
    my ( $twig, $href ) = @_;
    my $text = $href->text();
    $href->set_text('(OSt)20') if $text eq '(OSt)16';
}

[download]

In reply to Re: Replacing a text in XML. by toolic
in thread Replacing a text in XML. by bendon

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.