In addition to the comments that jeffa made regarding the performance benefits of using placeholders in DBI statements (the question mark), I'd like to mention something else about them.

Using bind variables can also plug up significant security holes. Imagine what happens if someone using the program manages to set $header to the following:

foo';DROP TABLE press_release;SELECT * FROM press_release WHERE header
+='foo

[download]

For databases that allow multiple SQL statements separated by semi-colons, this is how the SQL gets interpreted:

SELECT id FROM press_release WHERE header = 'foo';
DROP TABLE press_release;
SELECT * FROM press_release WHERE header='foo'

[download]

The last statement is a throwaway, but because the cracker has taken the time to balance the quotes, the database will happily attempt to execute all of the SQL statements. These may or may not succeed (depending upon permissions, foreign key constraints, etc.), but a cracker should never get this close to touching the database. Placeholders, in addition to benefitting performance, also plug this potentially huge security hole.

You can also protect yourself with the following changes:

$header    = $dbh->quote( $header );

# note the *lack* of single quotes around $header
$header_id = $dbh->prepare("SELECT id FROM press_releases WHERE header
+ = $header");

[download]

This works, but there are two problems with it:

  1. You lose the performance benefits of using placeholders and bind variables.
  2. It's easy to forget to quote the variable.

Stick with placeholders and your scripts will be much more secure.

Cheers,
Ovid

Vote for paco!

Join the Perlmonks Setiathome Group or just click on the the link and check out our stats.

In reply to (Ovid - security and bind variables) Re: Retrieval of ID# as Integer from MySQL by Ovid
in thread Retrieval of ID# as Integer from MySQL by cdherold

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.