You should show what code you used in your splice implementation, because it certainly could work, assuming you're using it right.

If I were doing this, and memory weren't a constraint, I would make a new array, and then replace the old one with the new one once done. The reason is that every time you insert into the middle of an array, all elements that follow must be shifted to the right one step, which is relatively expensive. Here's an example of how I would do it:

@array = do {
  my @array2;
  foreach ( @array ) {
    push @array2, $_;
    push @array2, "new_element" if $_ eq 'remove';
  }
  @array2;
};

[download]

Or, avoiding the temporary @array2:

@array = map { $_, ( $_ eq 'remove' ? "new element" : () ) } @array;

[download]

For additional efficiency, you might do it this way instead:

@array = map {    $array[$_], (  ($_+1) % 3 == 0  ?  "new element"  : 
+ ()  )    } 0 .. $#array;

[download]

The latter avoids a full string comparison on each iteration, by keeping track of index number rather than element contents.


Dave

In reply to Re: Adding an new element after every 5th element in array by davido
in thread Adding an new element after every 5th element in array by dvinay

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.