If you add use warnings; to the head of your script, Perl will tell you that the opening of the while loop:
while ($i = 1) {
contains a logic error: it re-initialises the variable to 1 on each loop iteration. In fact, this loop would benefit from a complete re-write:
use strict;
use warnings;
my $c;
for (my ($valid, $try) = (0, 1); !$valid; ++$try)
{
print "Enter the range of the array (try $try):\n";
chomp($c = <STDIN>);
if ($c =~ /^\d+$/)
{
print "You have entered a valid range: $c\n";
$valid = 1;
}
elsif ($try < 3)
{
print "The input is invalid, please enter digits only\n";
}
else
{
print "No valid array range entered, exiting\n";
exit;
}
}
print "Continuing...\n";
This is one of the unusual cases in which a C-style for loop is useful in Perl. Please note:
- I have also added use strict; and declared all variables as lexicals with my. The amount of time this will save you down the track far outweighs the (very small) extra effort required.
- In future, please put <code> ... </code> tags around your code, to make it readable.
- When asking a question (as opposed to commenting on someone else’s answer), it’s usually better to open a new thread.
Hope that helps,
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.