Project TempDir creation is insecure. The attacker will (a) observe or guess the cron process PID, (b) prepare a directory wherein a symlink service_foo -> some strategic path exists, (c) attempt to rename this to the cron job's TempDir at the critical moment before the invocation of mkdir but after the -d -e checks. Succeeding that, the privileged process will go on to overwrite some system file of your choosing. For the shoddy code in question, the attack is even simpler: neither rmdir nor unlink can remove a directory with files, so all the attacker needs to do is prepare 32766 tempdirs and wait for the hour to strike.

As for repair suggestions, mkdtemp, checking return values, and so on.

You're welcome.

Edit. The vulnerable section: 

$TempDir =  $TempDir. "project2." . $$ . "/";
if ( -d $TempDir ) {
    rmdir ($TempDir);
    #print "\nRemoving Existing Temp Dir";
}
if ( -e $TempDir ) {
    unlink ($TempDir);
    #print "\nRemoving the tempdir if it is existing as a file\n";
}
mkdir ($TempDir,0700);
print "\nMaking Temp Dir: " . $TempDir . "\n";

[download]

In reply to Re: Perl - Source code review by oiskuu
in thread Perl - Source code review by bheemamahesh

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.