I don't like your code to populate your hash, namely:

my ($key, $value) = split /\s/, $line; next LINE if not $key; $hash{$key} = $value; chomp (%hash);
Though the chomp(%hash) kinda "works", the doco for chomp does not mention applying it to a hash and accordingly, I feel this code is unclear. Update: Whoops, the chomp doco does indeed mention applying chomp to a hash, as pointed out below. Thanks AnomalousMonk.

I would do it something like this:

use strict; use warnings; use Data::Dumper; my %hash; open my $fh, '<', 'hash.txt' or die "Can't open file $!"; while (my $line = <$fh>) { chomp $line; # remove trailing newline $line =~ s/^\s+//; # optional: remove leading whitespa +ce $line =~ s/\s+$//; # optional: remove trailing whitesp +ace next unless length($line); # ignore blank lines next if $line =~ /^#/; # optional: to allow comment lines # Format: key whitespace value (value can contain whitespace) my ($key, $value) = split ' ', $line, 2; defined($value) or die "error: no value for '$key'"; $hash{$key} = $value; } close $fh; print Dumper(\%hash);

You might further want to consider what will happen if your key contains regex metachars (e.g. abc.xyz). Maybe this can't happen for your data ... but if it does, your regex may be incorrect (could use /\Q$key\E/ to escape metachars, if required by your data).

Re safely editing a file in place, see:


In reply to Re: In place search and replace with a hash by eyepopslikeamosquito
in thread In place search and replace with a hash by hkates

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.