In "Re: LeetCode Problem #1 - Two Sum - Improve and/or discuss.", you wrote:

"... you have to also allow the reverse order in your tests."

In "Re^2: LeetCode Problem #1 - Two Sum - Improve and/or discuss.", I replied to that saying that I agreed and that the spec had indeed said "any order". I changed @tests to include "any order".

In "Re^3: LeetCode Problem #1 - Two Sum - Improve and/or discuss.", you replied to that:

"not sure why you are duplicating the tests ... (?)"

There were no duplicates. I added (different) tests such that the result could be in "any order".

In "Re^5: LeetCode Problem #1 - Two Sum - Improve and/or discuss.", to which I'm now replying, you've removed the tests that allowed the results to be in "any order". You've modified is_deeply such that any additional tests added to @tests must have the results in ascending order for the is_deeply test to be successful. I do not agree that this is any sort of improvement; in fact, I'd consider it to be a bad move.

By the way, I don't see any difference between my &sort_arrayref and yours. I've looked closely at both; do let me know if I've missed something.

— Ken

In reply to Re^6: LeetCode Problem #1 - Two Sum - Improve and/or discuss. by kcott
in thread LeetCode Problem #1 - Two Sum - Improve and/or discuss. by kcott

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.