Hello noviceuser. Your code looks OK and will work, although there are a couple of things you might want to look at if interested.

open(MY_LOG, $log) or die "Could not open file 'log' $!";

Bareword filehandles like MY_LOG are apparently being phased out of the language. Instead you can use a lexical variable to hold the filehandle. eg:

open(my $lfh, $log) or die "Could not open file 'log' $!";

[download]

It's good that you have the conditional die statement, but it doesn't contain the filename which is another good piece of info to provide to the user on error, so I would include that too:

open(my $lfh, $log) or die "Could not open log file '$log': $!";

[download]

Presumably you are only opening the file for reading, so it's worth popping that in there as well:

open(my $lfh, '<', $log) or die "Could not open log file '$log': $!";

[download]

And finally, you don't need the brackets - they do no harm but you might find that the fewer punctuation characters there are on a line the easier it is to read.

open my $lfh, '<', $log or die "Could not open log file '$log': $!";

[download]

The other slightly odd thing is that you are chomping the lines read. Why is that? If the only action is to match against a pattern and conditionally print then it makes more sense not to chomp in this particular case.

These are all just "bonus" points but if you are just starting out with Perl now is a great time to try to reinforce good habits and best practices that will serve you well for a long time to come.

🦛

In reply to Re: print complete line along side line number, when a pattern is matched in log file by hippo
in thread print complete line along side line number, when a pattern is matched in log file by noviceuser

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.