I don't quite get this. From an object design standpoint, you have constant objects with no internal state, and an object class that is not particularly reusable because there's no real allowances for subclassable items. This means it's not really an object you want, but a package of subroutines instead. About the only thing you're using of the object-ness is the overloading.

Worse yet, the following code fails (I think): 

## first put all my favorite teams in a list:
my @favorites = map { Sports::Baseball::Teams->new($_) } qw(Sea Tex An
+a); 
## now, let's notice a particular team playing tonight
my $tonight = Sports::Baseball::Teams->new("Sea"); # seattle tonight
## let's see if this team playing tonight is one of my favorites:
if (grep $_ == $tonight, @favorites) {
  ## THIS WON'T BE TRUE, BUT IT SHOULD BE
}

[download]
The reason is that a unique instance is not returned for a given team. Each new call asking for Seattle will return a distinct Seattle object. That's bad. Real bad.

There's your initial review. To get more details, you'll have to pay me. {grin}

If you wanna learn objects well, get Squeak and play with it a bit. Smalltalk rocks.

-- Randal L. Schwartz, Perl hacker

In reply to Re: Sports::Baseball::Teams by merlyn
in thread Sports::Baseball::Teams by ChemBoy

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.