For situations where you have a stream of lines, a
here-doc can significantly improve readability. As well, a two-argument open without a check is considered bad practice. Combining all this with a lexical filehandle and
poj's suggestion, I might write your script as:
my $emailTo = 'Customer Service <customerservice@df-foods.com>';
my $emailCC = 'Frank Simmons <fsimmons@oregonpotato.com,susan@ftiegs.c
+om,jenbrink@icloud.com>';
my $emailFrom = FilterCChars($FTGEmail);
open(my $mail,'|-', $mailProg) or die "Problem accessing $mailProg: $!
+";
print $mail <<EOT;
To: $emailTo
Cc: $emailCC
From: $emailFrom
Subject: $emailSubject
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
$emailBody
EOT
close $mail;
# Redirect user to success page
print "Location: /thankyou.html\n\n";
exit;
Note how much cleaner that looks without all the newlines and print commands.
#11929 First ask yourself `How would I do this without a computer?' Then have the computer do it the same way.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.