I have thought again about this problem, and it seems to me that you could have avoided this problem by using an array instead of a hash in your sub - this will get you the correct (numeric) comparison and save you one sort:

sub find_holes { my @list = @{ shift() }; @list = sort { $a <=> $b } @list; my $low = $list[0]; my $high = $list[-1]; my @notfound; @notfound[$low..$high] = ($low..$high); $notfound[$_] = 0 for @list; my @vacancies = grep {$_} @notfound; return \@vacancies; }
Since the value of the array index is not accessible in a simple for loop, I set the values of the array equal to the index and inverted the sense of the final grep, but otherwise everything is as it was. Note that this code will fail (just like the original one) if 0 is contained in the interval $low .. $high. But this can easily be fixed by setting the values we found to undef rather than 0 and checking for defined values in the final grep...

pike


In reply to Use array instead of hash if all 'keys' are numeric by pike
in thread Finding missing elements in a sequence (code) by deprecated

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.