My first step would be to run perltidy on this script and actually get some indentation.

My second piece of advice is to break out more functions. A good rule of thumb is that if a function or block of straight code goes over 50 lines, you probably are doing something wrong. This is not always true, but it is true enough that it is worth asking yourself why the function is getting long.

A third piece of advice is that the logic about how your stock names relate to the array of values is entirely maintained in your code. This makes understanding your data structures much harder, and makes your code more fragile. Insert usual advice about using a hash, and using some looping logic. (Which would also remove a lot of repeated code.)

(These items significantly affect how easy your code is to follow, and how complex of programming tasks you can tackle.)

In reply to Re (tilly) 1: Seeking Feed Back on a Game by tilly
in thread Seeking Feed Back on a Game by Cobo

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.