A few things:

First off, use the File::Find module to recursively plow through directories. It is MUCH easier to work with than rolling your own script, and comes bundled with every version of perl.

Secondly, use strict and -w. They will help you write clean code, catch typos, and make your life easier.

Thirdly, on to your problem. I've rewritten your code to this: (using File::Find, strict, and -w)

#!perl -w use strict; use File::Find; my $path = $ARGV[0]; my $ct = 0; find (\&wanted, $path); print "Number of files changed: ", $ct, "\n"; sub wanted { if ($_ ne lc($_)) { my $newname = lc($_); rename ($File::Find::name, $File::Find::dir . $newname); print $_, " was changed to ", $newname, "\n"; $ct++; } }

If you have any questions about the above code, please reply so that we can clear up any everything.


In reply to Re: Renaming Sub Dir/Files. by jryan
in thread Renaming Sub Dir/Files. by JoeCool

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.