That's decent code as it is. I can help with the range, though, if I'm reading it correctly. Try this:
for my $aref (@$STF3) {
print OUTPUT qq|<li>$aref->[0] </li><a href="$aref->[1}$STF3_Table
+s">$aref->[2]</a><br />\n|;
}
You could even throw
printf in there, if you were so inclined.
Stylisticly, you can give a list of variables to my, and you usually don't need to initialize them explicitly. I generally say my ($foo, $bar, @baz, %kudra);.
You can also get rid of temporaries, like so:
return split(/\n/, $document);
return \@STF1, \@STF3;
It also wouldn't hurt to
select the OUTPUT filehandle. The only thing I'd ding you for on a code review would be the loops, and that's because you're only hurting yourself there. :)
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.