First, a comment on your coding style .. it seems that you have declared a whack of variables that get set elsewhere (so we're missing the code that sets $article_title, $article_id). You're also passing these global variables into the subroutine edit_news in your mainline, but you don't catch those variables as parameters in the subroutine itself. I suggest you pick one style and stick with it -- globals or parameters (hint: parameters are far more preferable to globals).

My preference is always to put the mainline inside braces to make it clearer what's going on. In addition, the conditionals you havein your mainline could be organized a little better: 

  if ( $vars { action } )
  {
    if ( $vars{action} eq "news" )
    {
      &news if (!$vars{article});
      &show_news if ($vars{article} || $vars{editnews});
    }
    elsif ( $vars{action} eq "editnews" )
    {
      &edit_news($article_title, $article_body);
    }
  }
  else
  {
    &left_content();
    &right_content();
  }

[download]

Second .. what SQL is being generated? Are you sure that it's correct? Perhaps try turning on DBI->trace to see what DBI is doing.

--t. alex

"Nyahhh (munch, munch) What's up, Doc?" --Bugs Bunny

Update Fixed some typos.

In reply to Re: Editing data extracted from mysql through CGI/mod_perl by talexb
in thread Editing data extracted from mysql through CGI/mod_perl by hacker

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.