It looks like it should work...

In this small snippet of code you never print your changes back to the file. You read a line in, manipulate it and throw it away. Remember that $_ holds the contents of the line. It is not the line itself.

Your immediate thought might be to add 

print FETCHMAILRC $_;

[download]
to the bottom of your while loop, but this won't work either. It won't work because your file pointer telling you where you've read up to has been incremented to the end of the line you've read. So printing out what you've just read will duplicate it in the file.

What is more, when you print this line back to the file you move the file pointer on again, so your file will end up completely corrupted. A way to get around that is to use seek lots, but that's beginning to get masochistic.

If you don't like merlyn's excellent suggestion (although who wouldn't?) you can also do it this way: 

open(FETCHMAILRC, '< .fetchmailrc') or die "Unable to open FMRC for re
+ading. $!";
my $filecontents;
while (<FETCHMAILRC>) {
    s/^here/$username\nhere/i;
    $filecontents .= $_;
}
close FETCHMAILRC or die "Close on FMRC died: $!";

        # clobber file and open for writing
open(FETCHMAILRC, "> .fetchmailrc') or die "Unable to open FMRC for wr
+iting. $!";
print FETCHMAILRC $filecontents;
close FETCHMAILRC or die "Close on FMRC died: $!";

[download]
Note that I snuck $! into those die statements too. $! tells you what just went wrong, so rather than just being told that you were unable to open FRMC for reading you'll be told why: file doesn't exist, permission denied etc. If there is any chance whatsoever that more than one process might try to do this at a time then you really must look into locking. There are many excellent nodes around here discussing locking in detail.

Hope it helps.

jarich

In reply to Re: Editing Files In Place by jarich
in thread Editing Files In Place by gnubbs

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.