tstock gave you some good refactoring ideas, how about
some good formatting ideas? I ran your code through
perltidy:
#!/usr/local/bin/perl -w
use strict;
open( FH, "userlist" ) || die "no userlist: $!";
open( FH2, ">output" ) || die "no output file: $!";
while (<FH>) {
chomp;
my $file = ("/usr/home/$_/INBOX");
my $maxsize = ( 30000 * 1024 );
if ( -s $file ) {
my $size = ( stat $file )[7];
my $meg = int( $size / 1024000 );
if ( $size > $maxsize ) {
printf "%25s %3sMB\n", $_, $meg;
print FH2 "$_:$meg\n";
}
}
}
close(FH) || die "couldn't close userlist: $!:";
close(FH2) || die "couldn't close output: $!";
With the original code i really had to squint to notice
that you were indeed unecessarily calculating the max
size inside the while loop.
jeffa
L-LL-L--L-LL-L--L-LL-L--
-R--R-RR-R--R-RR-R--R-RR
B--B--B--B--B--B--B--B--
H---H---H---H---H---H---
(the triplet paradiddle with high-hat)
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.