for ( my $i = scalar(@$results) - 1; $i >= 0; $i-- ){ for ( my $j = 1; $j <= $i; $j++){ if ( $$results[$j - 1]{'hits'} < $$results[$j]{'hits'} ){ my $temp = $$results[$j - 1]; $$results[$j - 1] = $$results[$j]; $$results[$j] = $temp; } } }
This is the first thing that stands out. I am guessing that you want the ones with the most 'hits' first correct? Why not just use a simple sort. For example, I think this has the same functionality as the above code without me trying to figure out exactly what it was I was trying to accomplish a couple of months down the road (not that commenting it wouldn't help in this respect.)
@$results = sort{ $b->{'hits'} <=> $a->{'hits'} } @$results;
Even if you don't want to take it this far you can exchange these couple lines
my $temp = $$results[$j - 1]; $$results[$j - 1] = $$results[$j]; $$results[$j] = $temp;
with
($$results[$j - 1], $$results[$j]) = ($$results[$j],$$results[$j - 1])
which is similar to one of the first things i remember seeing in the camel (the swapping without a temporary variable thing.

Though there might be more things this just stuck out at me as more a C type thing than a Perl type thing

-enlil


In reply to Re: Search engine code critique by Enlil
in thread Search engine code critique by ruhk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.