I looked at the code briefly and I noticed a few things you should concern yourself with.

Here's a code snipped from the index.pl:

my $User = $CommonObject{ParamObject}->GetParam(Param => 'User') || ' +'; my $Pw = $CommonObject{ParamObject}->GetParam(Param => 'Password') + || '';
I don't know about you but this seems like a hell of a lot of overhead to get a darn username and password! The CGI stuff should be a higher level object rather than nested down so far. Looking randomly at other code makes me think that OO programming went to some kind of extreme here. Perhaps the developers are used to another language?

Also, if I am right and the index.pl file is the starting point for this program (didn't have enough time to read the DOCS, sorry!) then it is NOT running in taint mode, which is not a problem if you are doing all of the stuff that taint mode insists that you do, but somehow I don't think that it is the case here. You are welcome to check for youself though.

#!/usr/bin/perl -wT #where art thou?
Lastly, there are tons of .DTL files which looks like some kind of proprietary version of Embperl. I probably would have just used Embperl instead unless there was a good reason not to use it.

Celebrate Intellectual Diversity


In reply to Re: Request for Comment on OTRS by InfiniteSilence
in thread Request for Comment on OTRS by HyperZonk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.