Nice piece of simple code, but I'd like to add just a few lines to make the error handling a little nicer if the file in @ARGV doesn't exist ;)

Right now, if I use a non existant file I get a lot of irrelevant (for the user) data:

$ ./unzipper nonexistant.zip
IO error: opening nonexistant.zip for read : No such file or directory
+ 
        Archive::Zip::Archive::read('Archive::Zip::Archive=HASH(0x8120
+258)','nonexistant.zip') called at /usr/local/lib/perl5/site_perl/5.8
+.0/Archive/Zip.pm line 522
        Archive::Zip::Archive::new('Archive::Zip::Archive','nonexistan
+t.zip') called at /usr/local/lib/perl5/site_perl/5.8.0/Archive/Zip.pm
+ line 211
        Archive::Zip::new('Archive::Zip','nonexistant.zip') called at 
+./unzipper line 6
Unable to open nonexistant.zip:   at ./unzipper line 6.
[download]

This can be solved by just a few extra lines:

#!/usr/bin/perl -w

use Archive::Zip;

for (@ARGV) {
 if(! -r $_) {
   print "$_: $!\n";
   exit 1;
 }
 print "Unzipping: $_\n" if $debug;
 my $zip = Archive::Zip->new($_) or die "Unable to open $_:  $!";
 for my $m ($zip->members()) {
   print "  Member: ".Dumper($m)."\n" if $debug;
   # $m is an object of class Archive::Zip::ZipFileMember
   print "  ".$m->fileName()."$/";
   $zip->extractMember($m);
 }
}
[download]

Now the error will be slightly more helpful to l-users

$ ./unzipper nonexistant.zip
nonexistant.zip: No such file or directory
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.