Basically, the problem is simply that your random image selection and 'Location: ...' printing statements are inside the foreach loop.
Also, you want to push $image to @imgs, not assign it. 
if(!open DAT, "ads.dat") {
    print "Error: cannot open data file!\n";
    exit 1;
} else {

    @imgdata=<DAT>;
    foreach $c (@imgdata) {
        ($id,$image,$url,$type)=split(/\|/,$c);

        if ($type=~/^(internal|partner)$/) {
            push (@imgs, $image);
        }
    }

    $img  = $imgs[int(rand($#imgs+1))];
    print "Location: $img\n\n";
}

[download]

In reply to Re: Printing Random Image in HTML by kilinrax
in thread Printing Random Image in HTML by damian

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.